Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With Win CI #2

Closed
wants to merge 11 commits into from
Closed

With Win CI #2

wants to merge 11 commits into from

Conversation

yamachu
Copy link
Owner

@yamachu yamachu commented Jan 21, 2025

No description provided.

cjihrig and others added 6 commits January 18, 2025 18:01
DEP0040 is an extremely annoying warning. Most of the people
seeing it cannot do anything about it. This commit updates the
warning logic to only emit outside of node_modules. This is
similar to other warnings such as the Buffer() constructor
warning.

Ideally, this should be backported to Node 22.

Refs: nodejs#47202
PR-URL: nodejs#56632
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Fixes: nodejs#55834
PR-URL: nodejs#56106
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Enforce that it is u8 because it was crashing
when loading files containing Japanese in Windows, cp392 environment.

Fixes: nodejs#56650
@yamachu yamachu force-pushed the with-win-ci branch 2 times, most recently from 2c318e8 to 8f93b80 Compare January 22, 2025 06:46
@yamachu
Copy link
Owner Author

yamachu commented Jan 25, 2025

resolved

@yamachu yamachu closed this Jan 25, 2025
@yamachu yamachu deleted the with-win-ci branch January 25, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants